-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the module structure of the namespace module #6291
Draft
jjcnn
wants to merge
51
commits into
master
Choose a base branch
from
jjcnn/move-external-modules-to-root
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-namespace-module
…ernal-modules-to-root
…ernal-modules-to-root
CodSpeed Performance ReportMerging #6291 will improve performances by 13.35%Comparing Summary
Benchmarks breakdown
|
…ernal-modules-to-root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial fix of #5498 .
The namespace module is used to represents the environment of bindings during compilation.
Until now we have treated external libraries as submodules of each module in the program being compiled. This leads to some illegal paths suddenly becoming legal. Additionally, the namespace module suffers from excessive cloning because external modules get cloned each time a new module is compiled. The treatment also means that path resolution must take into account whether a module is external or not.
This PR streamlines the module structure and the paths used in the environment. External modules are now represented separately from the current package, and path resolution is changed to take this separation into account. This allows us to eleminate a significant part of the excessive cloning, though there is still some cloning happening in the AST.
Current state:
Checklist
Breaking*
orNew Feature
labels where relevant.